API review

Proposer: Wim Meeussen

Present at review:

  • List reviewers

Question / concerns / comments

Enter your thoughts on the API and any questions / concerns you have here. Please sign your name. Anything you want to address in the API review should be marked down here before the start of the meeting.

Vijay

  • What is the reason for namespacing everything as pr2_mechanism? Should it be pr2_mechanism_model instead?

  • It seems like the main purpose of pr2_mechanism::Chain is to generate a KDL::Chain. Since KDL::Tree works well with the URDF, do we need the chain class?

Stu

  • Remove GripperTransmission

  • Robot has initXml. Should it be initialized from URDF instead?

Meeting agenda

  • namespace should match package name
  • Chain stays
  • Remove gripper transmission and nonlinear transmission

Conclusion

Package status change mark change manifest)

  • /!\ Action items that need to be taken.

  • {X} Major issues that need to be resolved


Wiki: pr2_mechanism_model/Reviews/2009-10-16_API_Review (last edited 2009-10-16 23:12:28 by wim)