API review

Proposer: Jeremy Leibs

Present at review:

  • List reviewers

Question / concerns / comments

Enter your thoughts on the API and any questions / concerns you have here. Please sign your name. Anything you want to address in the API review should be marked down here before the start of the meeting.

  • Since this is the first data provider which needs to have it's frame_id dynamically set, I'd like to review the thoughts on frame_id management. Currently it's read as a parameter at startup. Is this adaquate? Should it be checking for changes? This will be the model for all other broadcasters. -TullyFoote

Meeting agenda

  • Frame ID management
  • Min/max ang parameters are specified in degrees (bad!)
    • Typing radians is unfortunately inconvenient for human use. Other possibilities:
      • String: 90deg
      • Double: 1.57079633 (Lazy can lead to laser scanning from -89.75deg to +89.75deg but maybe this isn't a problem)
      • String: pi/2
      • Device native resolution is degrees. .25 degree angular resolution
  • How to query parameter ranges
  • Changing parameters during runtime


Conditional Pass

  • /!\ Change max and min ang to have degrees in name

  • /!\ Change laser scan message to float64s

Wiki: hokuyo_node/Reviews/2008-09-25_API_Review (last edited 2009-08-14 20:52:28 by localhost)